Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10832105: Ensure that the WebstoreInstaller is always deleted on the UI thread (Closed)

Created:
8 years, 4 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 4 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Ensure that the WebstoreInstaller is always deleted on the UI thread The crash stacks show a CHECK failure when doing the unregistration due to NotificationRegistrar deletion, indicating that the WebstoreInstaller is getting deleted on a different thread from where the original notification registration took place. This CL makes the ref counting infrastructure always do the delete on the UI thread instead of whichever thread happened to do the last Release, which should hopefully fix the problem. BUG=125485 TEST=CHECK failures with a stack matching the signature in the bug report should stop appearing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149646

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/extensions/webstore_installer.h View 3 chunks +8 lines, -4 lines 1 comment Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asargent_no_longer_on_chrome
8 years, 4 months ago (2012-08-02 00:01:19 UTC) #1
miket_OOO
lgtm http://codereview.chromium.org/10832105/diff/1/chrome/browser/extensions/webstore_installer.h File chrome/browser/extensions/webstore_installer.h (right): http://codereview.chromium.org/10832105/diff/1/chrome/browser/extensions/webstore_installer.h#newcode33 chrome/browser/extensions/webstore_installer.h:33: class WebstoreInstaller :public content::NotificationObserver, I liked the old ...
8 years, 4 months ago (2012-08-02 15:53:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10832105/1
8 years, 4 months ago (2012-08-02 16:00:23 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 17:23:52 UTC) #4
Change committed as 149646

Powered by Google App Engine
This is Rietveld 408576698