Issue 10832104: Start upstreaming accessibility.

Issue 10832104: Start upstreaming accessibility. (Closed)

Created:
8 years, 4 months ago by David Trainor- moved to gerrit

Modified:
8 years, 4 months ago

Reviewers:
Ted C, Yaron, gone

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start upstreaming accessibility. BUG=http://crbug.com/138218 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149667

Patch Set 1 #

Patch Set 2 : Add onPause/onResume support #

Patch Set 3 : Personal Pass Nits #

Patch Set 4 : Add permissions for vibrate to the content shell. #

Total comments: 11

Patch Set 5 : Nit Fixes #

Total comments: 4

Patch Set 6 : Address Dan's Nits #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+602 lines, -10 lines)			Patch
M	content/public/android/java/src/org/chromium/content/browser/ContentView.java	View	1 2 3 4 5	4 chunks	+98 lines, -7 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 2 3 4	10 chunks	+97 lines, -2 lines	0 comments	Download
A	content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java	View		1 chunk	+375 lines, -0 lines	0 comments	Download
M	content/shell/android/java/AndroidManifest.xml	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java	View	1 2	2 chunks	+25 lines, -0 lines	0 comments	Download
M	content/shell/android/java/src/org/chromium/content_shell/Shell.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/android/java/src/org/chromium/content_shell/ShellManager.java	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

David Trainor- moved to gerrit

Starting to upstream accessibility. JellyBean classes will have to wait for the SDK to hit ...

8 years, 4 months ago (2012-08-02 00:44:28 UTC) #1

Ted C

nits https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode364 content/public/android/java/src/org/chromium/content/browser/ContentView.java:364: **/ unnecessary blank line or ** on the ...

8 years, 4 months ago (2012-08-02 01:04:19 UTC) #2

David Trainor- moved to gerrit

https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode364 content/public/android/java/src/org/chromium/content/browser/ContentView.java:364: **/ On 2012/08/02 01:04:20, Ted C wrote: > unnecessary ...

8 years, 4 months ago (2012-08-02 15:18:54 UTC) #3

Yaron

https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode390 content/public/android/java/src/org/chromium/content/browser/ContentView.java:390: * @hide On 2012/08/02 15:18:54, dtrainor wrote: > On ...

8 years, 4 months ago (2012-08-02 15:31:13 UTC) #4

David Trainor- moved to gerrit

On 2012/08/02 15:31:13, Yaron wrote: > https://chromiumcodereview.appspot.com/10832104/diff/5001/content/public/android/java/src/org/chromium/content/browser/ContentView.java > File > content/public/android/java/src/org/chromium/content/browser/ContentView.java > (right): > > ...

8 years, 4 months ago (2012-08-02 15:45:32 UTC) #5

gone

LGTM, with nits. https://chromiumcodereview.appspot.com/10832104/diff/9001/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://chromiumcodereview.appspot.com/10832104/diff/9001/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode362 content/public/android/java/src/org/chromium/content/browser/ContentView.java:362: * This method should be called ...

8 years, 4 months ago (2012-08-02 17:19:10 UTC) #8

David Trainor- moved to gerrit

https://chromiumcodereview.appspot.com/10832104/diff/9001/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://chromiumcodereview.appspot.com/10832104/diff/9001/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode362 content/public/android/java/src/org/chromium/content/browser/ContentView.java:362: * This method should be called when the containing ...

8 years, 4 months ago (2012-08-02 17:35:28 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10832104/1006

8 years, 4 months ago (2012-08-02 17:36:05 UTC) #10

Change committed as 149667

Expand Messages | Collapse Messages