Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: net/spdy/spdy_test_util_spdy3.h

Issue 10832098: Simplify the EC signature creation code by moving it to a Helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix raman's comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_stream_spdy3_unittest.cc ('k') | net/spdy/spdy_test_util_spdy3.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_spdy3.h
diff --git a/net/spdy/spdy_test_util_spdy3.h b/net/spdy/spdy_test_util_spdy3.h
index 5b7b56a314c8e545ed8e682eeb9f25ed0caf7025..6f0d388a2c15368693b098ac4aa0c83eb47a0805 100644
--- a/net/spdy/spdy_test_util_spdy3.h
+++ b/net/spdy/spdy_test_util_spdy3.h
@@ -6,6 +6,7 @@
#define NET_SPDY_SPDY_TEST_UTIL_H_
#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
#include "net/base/cert_verifier.h"
#include "net/base/host_port_pair.h"
#include "net/base/mock_host_resolver.h"
@@ -22,6 +23,10 @@
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_storage.h"
+namespace crypto {
+class ECSignatureCreatorFactory;
+}
+
namespace net {
namespace test_spdy3 {
@@ -422,6 +427,11 @@ class SpdyTestStateHelper {
~SpdyTestStateHelper();
private:
+ // In order to make CREDENTIAL frame creation deterministic, we need to
+ // use a mock EC signature creator, which needs to live throughout
+ // the life of the test.
+ scoped_ptr<crypto::ECSignatureCreatorFactory> ec_signature_creator_factory_;
+
DISALLOW_COPY_AND_ASSIGN(SpdyTestStateHelper);
};
« no previous file with comments | « net/spdy/spdy_http_stream_spdy3_unittest.cc ('k') | net/spdy/spdy_test_util_spdy3.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698