Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10832096: Make FileCopyManager work on harness. (Closed)

Created:
8 years, 4 months ago by Oleg Eterevsky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Make FileCopyManager work on harness. Remove mocks for v8Intl which is live in 21. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149428

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -41 lines) Patch
M chrome/browser/resources/file_manager/js/metrics.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 3 chunks +17 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Oleg Eterevsky
8 years, 4 months ago (2012-08-01 13:18:14 UTC) #1
SeRya
lgtm
8 years, 4 months ago (2012-08-01 13:25:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10832096/1
8 years, 4 months ago (2012-08-01 13:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10832096/5
8 years, 4 months ago (2012-08-01 15:22:43 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 16:42:29 UTC) #5
Change committed as 149428

Powered by Google App Engine
This is Rietveld 408576698