Issue 10832095: Prevent traps after rsp modification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832095: Prevent traps after rsp modification (Closed)

Created:
8 years, 4 months ago by eaeltsin

Modified:
8 years, 4 months ago

Reviewers:
halyavin

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master

Visibility:
Public.

More Reviews

Description

Prevent traps after rsp modification If trap happens after rsp is modified but before it is sandboxed, Win exception handler fails to run. This applies to breakpoints and hardware-supported single step. We fix these by: - use software single step to step both rsp modification and rsp sandboxing at once - moving breakpoints from after rsp modification to after rsp sandboxing BUG=http://code.google.com/p/nativeclient/issues/detail?id=2903 Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=7c746d1

Patch Set 1 #

Patch Set 2 : allow any instruction before rsp sandboxing #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
	M	gdb/nacl-tdep.c	View	1	3 chunks	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages