Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: tests/utils/uri_test.dart

Issue 10832092: Added origin property to Uri class Added unit test coverage for origin property (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Validate scheme, domain. TODO in place for IllegalArgumentException->StateException. Use Expect.thr… Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/uri/uri.dart ('K') | « lib/uri/uri.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/utils/uri_test.dart
diff --git a/tests/utils/uri_test.dart b/tests/utils/uri_test.dart
index ff03d4a35e19747844392b33c32dec047d68db15..d2e959a1ddf938f191424cd2cf27d7501e01f763 100644
--- a/tests/utils/uri_test.dart
+++ b/tests/utils/uri_test.dart
@@ -106,6 +106,46 @@ main() {
Expect.stringEquals("http://a/b/g;p/h;s",
base.resolve("../g;p/h;s").toString());
+ Expect.stringEquals(
+ "http://example.com",
+ new Uri.fromString("http://example.com/a/b/c").origin);
+ Expect.stringEquals(
+ "https://example.com",
+ new Uri.fromString("https://example.com/a/b/c").origin);
+ Expect.stringEquals(
+ "http://example.com:1234",
+ new Uri.fromString("http://example.com:1234/a/b/c").origin);
+ Expect.stringEquals(
+ "https://example.com:1234",
+ new Uri.fromString("https://example.com:1234/a/b/c").origin);
+ Expect.throws(
+ () => new Uri.fromString("http:").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for uri with empty domain should fail");
+ Expect.throws(
+ () => const Uri("http", null, "", 80, "/a/b/c",
ahe 2012/08/21 20:36:28 You probably need to update this to use fromCompon
+ "query", "fragment").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for uri with empty domain should fail");
+ Expect.throws(
+ () => const Uri(null, null, "", 80, "/a/b/c",
+ "query", "fragment").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for uri with empty scheme should fail");
+ Expect.throws(
+ () => const Uri("http", null, null, 80, "/a/b/c",
+ "query", "fragment").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for uri with empty domain should fail");
+ Expect.throws(
+ () => new Uri.fromString("http://:80").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for uri with empty domain should fail");
+ Expect.throws(
+ () => new Uri.fromString("file://localhost/test.txt").origin,
+ (e) { return e is IllegalArgumentException; },
+ "origin for non-http/https uri should fail");
+
// URI encode tests
// Note: dart2js won't handle '\ud800\udc00' and frog
// won't handle '\u{10000}'. So we cons this up synthetically...
« lib/uri/uri.dart ('K') | « lib/uri/uri.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698