Added origin property to Uri class Added unit test coverage for origin property

lib/uri/uri.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('dart:uri');
 
 #import('dart:utf');
 
 #source('encode_decode.dart');
 #source('helpers.dart');
@@ skipping 149 matching lines @@
       targetScheme = this.scheme;
     }
     return new Uri(targetScheme, targetUserInfo, targetDomain, targetPort,
                    targetPath, targetQuery, reference.fragment);
   }
 
   bool hasAuthority() {
     return (userInfo != "") || (domain != "") || (port != 0);
   }
 
+ /**
+   * Returns URI's origin: scheme://domain:port for http/https schemes
+   * Throws IllegalArgumentException for all other schemes
+   * See (http://www.w3.org/TR/2011/WD-html5-20110405/origin-0.html#origin)
+   */
+  String get origin() {

[ahe, 2012/08/07 06:32:36]

Please add something like:

if (scheme == "") {
  throw new StateException("Cannot use origin without a scheme");
}

+    if (scheme != "http" && scheme != "https") {
+      throw new IllegalArgumentException(

[ahe, 2012/08/07 06:32:36]

This should be a StateException which is coming soon. Please add a TODO, like:

// TODO(aprelev@gmail.com): Use StateException instead.

+        "origin is applicable to http/https schemes only. Not \'$scheme\'");
+    }
+    StringBuffer sb = new StringBuffer();
+    _addIfNonEmpty(sb, scheme, scheme, ':');

[ahe, 2012/08/07 06:32:36]

scheme is never empty now.

+    if (domain != null || port != 0) {

[ahe, 2012/08/07 06:32:36]

Right now, the invariant is that domain is never null. I do have a CL to change
that, but I think this needs to be something like:

if (domain === null || domain == "") throw StateException...

+      sb.add("//");
+      sb.add(_emptyIfNull(domain));
+      if (port != 0) {
+        sb.add(":");
+        sb.add(port.toString());
+      }
+    }
+    return sb.toString();
+  }
+
   String toString() {
     StringBuffer sb = new StringBuffer();
     _addIfNonEmpty(sb, scheme, scheme, ':');
     if (hasAuthority() || (scheme == "file")) {
       sb.add("//");
       _addIfNonEmpty(sb, userInfo, userInfo, "@");
       sb.add(domain === null ? "null" : domain);
       if (port != 0) {
         sb.add(":");
         sb.add(port.toString());
       }
     }
     sb.add(path === null ? "null" : path);
     _addIfNonEmpty(sb, query, "?", query);
     _addIfNonEmpty(sb, fragment, "#", fragment);
     return sb.toString();
   }
 
   static void _addIfNonEmpty(StringBuffer sb, String test,
                              String first, String second) {
     if ("" != test) {
       sb.add(first === null ? "null" : first);
       sb.add(second === null ? "null" : second);
     }
   }
 }
+

[ahe, 2012/08/07 06:32:36]

Extra line at end of file.