Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832087: Remove VideoDecoderConfig.frame_rate_xxx() & VideoFrame:Get/SetDuration() (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove VideoDecoderConfig.frame_rate_xxx() and VideoFrame::Get/SetDuration(). BUG=139455 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149274

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address CR comments & build issues. #

Total comments: 4

Patch Set 3 : Address more CR comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -203 lines) Patch
M content/renderer/media/capture_video_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/base/video_decoder_config.h View 4 chunks +0 lines, -13 lines 0 comments Download
M media/base/video_decoder_config.cc View 8 chunks +0 lines, -22 lines 0 comments Download
M media/base/video_frame.h View 5 chunks +4 lines, -15 lines 0 comments Download
M media/base/video_frame.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M media/base/video_frame_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M media/base/video_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 4 chunks +1 line, -29 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 2 4 chunks +4 lines, -13 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 2 5 chunks +7 lines, -27 lines 0 comments Download
M media/filters/video_frame_generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/video_renderer_base.h View 2 chunks +7 lines, -0 lines 0 comments Download
M media/filters/video_renderer_base.cc View 5 chunks +27 lines, -27 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M media/mp4/mp4_stream_parser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/tools/scaler_bench/scaler_bench.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M media/tools/shader_bench/cpu_color_painter.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/shader_bench/shader_bench.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
acolwell GONE FROM CHROMIUM
8 years, 4 months ago (2012-07-31 17:44:22 UTC) #1
scherkus (not reviewing)
drive-by -- also this CL does more than the description advertises, namely no longer writing/reading ...
8 years, 4 months ago (2012-07-31 17:52:04 UTC) #2
acolwell GONE FROM CHROMIUM
On 2012/07/31 17:52:04, scherkus wrote: > drive-by -- also this CL does more than the ...
8 years, 4 months ago (2012-07-31 17:57:06 UTC) #3
Ami GONE FROM CHROMIUM
\o/ http://codereview.chromium.org/10832087/diff/1/media/filters/gpu_video_decoder.cc File media/filters/gpu_video_decoder.cc (right): http://codereview.chromium.org/10832087/diff/1/media/filters/gpu_video_decoder.cc#newcode288 media/filters/gpu_video_decoder.cc:288: void GpuVideoDecoder::GetBufferTimeData( this could just return the timedelta ...
8 years, 4 months ago (2012-07-31 18:13:52 UTC) #4
Ami GONE FROM CHROMIUM
also, LGTM
8 years, 4 months ago (2012-07-31 18:13:57 UTC) #5
scherkus (not reviewing)
http://codereview.chromium.org/10832087/diff/1/media/base/video_frame.h File media/base/video_frame.h (left): http://codereview.chromium.org/10832087/diff/1/media/base/video_frame.h#oldcode112 media/base/video_frame.h:112: base::TimeDelta GetDuration() const { \o/!!!
8 years, 4 months ago (2012-07-31 18:24:40 UTC) #6
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/10832087/diff/1/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (left): http://codereview.chromium.org/10832087/diff/1/media/filters/ffmpeg_video_decoder.cc#oldcode531 media/filters/ffmpeg_video_decoder.cc:531: (*video_frame)->SetDuration( On 2012/07/31 17:52:04, scherkus wrote: > if duration ...
8 years, 4 months ago (2012-07-31 18:41:23 UTC) #7
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/10832087/diff/1023/media/filters/gpu_video_decoder.cc File media/filters/gpu_video_decoder.cc (right): http://codereview.chromium.org/10832087/diff/1023/media/filters/gpu_video_decoder.cc#newcode287 media/filters/gpu_video_decoder.cc:287: return it->second; now that you're returning the value it'd ...
8 years, 4 months ago (2012-07-31 18:44:42 UTC) #8
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/10832087/diff/1023/media/filters/gpu_video_decoder.cc File media/filters/gpu_video_decoder.cc (right): http://codereview.chromium.org/10832087/diff/1023/media/filters/gpu_video_decoder.cc#newcode287 media/filters/gpu_video_decoder.cc:287: return it->second; On 2012/07/31 18:44:42, Ami Fischman wrote: > ...
8 years, 4 months ago (2012-07-31 19:23:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10832087/7004
8 years, 4 months ago (2012-07-31 19:45:08 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 21:10:56 UTC) #11 
Change committed as 149274

Powered by Google App Engine
This is Rietveld 408576698