Issue 10832084: Fixed race condition in media_stream_infobar.py.

Issue 10832084: Fixed race condition in media_stream_infobar.py. (Closed)

Created:
8 years, 4 months ago by phoglund_chromium

Modified:
8 years, 4 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed race condition in media_stream_infobar.py. BUG= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149401

Patch Set 2 : Review updates #

Total comments: 1

Patch Set 3 : Added docstrings #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -18 lines)			Patch
M	chrome/test/functional/media_stream_infobar.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/test/functional/webrtc_call.py	View	1	3 chunks	+4 lines, -16 lines	0 comments	Download
A	chrome/test/functional/webrtc_test_base.py	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

Back from vacation! Here I'm fixing a race condition which breaks on slow bots. This ...

8 years, 4 months ago (2012-07-31 16:07:56 UTC) #1

Nirnimesh

http://codereview.chromium.org/10832084/diff/1/chrome/test/functional/webrtc_test_base.py File chrome/test/functional/webrtc_test_base.py (right): http://codereview.chromium.org/10832084/diff/1/chrome/test/functional/webrtc_test_base.py#newcode7 chrome/test/functional/webrtc_test_base.py:7: need another blank line here http://codereview.chromium.org/10832084/diff/1/chrome/test/functional/webrtc_test_base.py#newcode11 chrome/test/functional/webrtc_test_base.py:11: def _WaitForGetUserMediaResult(self, ...

8 years, 4 months ago (2012-07-31 20:10:09 UTC) #2

phoglund_chromium

PTAL http://codereview.chromium.org/10832084/diff/1/chrome/test/functional/webrtc_test_base.py File chrome/test/functional/webrtc_test_base.py (right): http://codereview.chromium.org/10832084/diff/1/chrome/test/functional/webrtc_test_base.py#newcode7 chrome/test/functional/webrtc_test_base.py:7: On 2012/07/31 20:10:09, Nirnimesh wrote: > need another ...

8 years, 4 months ago (2012-08-01 07:08:39 UTC) #3

Nirnimesh

lgtm http://codereview.chromium.org/10832084/diff/4001/chrome/test/functional/webrtc_test_base.py File chrome/test/functional/webrtc_test_base.py (right): http://codereview.chromium.org/10832084/diff/4001/chrome/test/functional/webrtc_test_base.py#newcode12 chrome/test/functional/webrtc_test_base.py:12: def WaitForGetUserMediaResult(self, tab_index): docstring please

8 years, 4 months ago (2012-08-01 11:18:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/10832084/8001

8 years, 4 months ago (2012-08-01 11:27:44 UTC) #5

Change committed as 149401

Expand Messages | Collapse Messages