Properly emit and rename generic types.

lib/compiler/implementation/dart_backend/renamer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Renames only top-level elements that would let to ambiguity if not renamed.
  * TODO(smok): Make sure that top-level fields are correctly renamed.
  */
 class ConflictingRenamer extends Renamer {
   final Compiler compiler;
@@ skipping 25 matching lines @@
     if (element.isTopLevel()) {
       return renameElement(element);
     } else if (
         (element.isGenerativeConstructor() || element.isFactoryConstructor())
         && element.asFunctionElement().cachedNode.name is Send
         // Don't want to rename redirects to :this(args).
         && !Initializers.isConstructorRedirect(send)
         // Don't want to rename super calls.
         && !Initializers.isSuperConstructorCall(send)) {
       FunctionExpression constructor = element.asFunctionElement().cachedNode;
-      return '${renameType(element.getEnclosingClass().type)}'
-          '.${getFactoryName(constructor)}';
+      TypeAnnotation typeAnnotation;
+      if (send.selector is TypeAnnotation) {

[Roman, 2012/07/31 15:35:39]

Please add comments for these ifs about what original source structure we have
here and why we select receiver or selector for further unparse.

[Anton Muhin, 2012/07/31 15:46:47]

Done.

+        typeAnnotation = send.selector;
+      } else if (send.selector.receiver is TypeAnnotation) {
+        typeAnnotation = send.selector.receiver;
+      } else {
+        compiler.cancel(
+          reason: "Don't know how to deduce type",
+          element: element,
+          node: send);
+      }
+      final type = new Unparser(this).unparse(typeAnnotation);
+      return '$type.${getFactoryName(constructor)}';
     } else {
       return null;
     }
   }
 
   String renameTypeName(TypeAnnotation typeAnnotation) {
     Type type;
     if (context.isClass()) {
       // This only happens if we're unparsing class declaration.
       type = new TypeResolver(compiler)
@@ skipping 42 matching lines @@
     final library = element.getLibrary();
     if (library === compiler.coreLibrary) return originalName;
     if (isDartCoreLib(compiler, library)) {
       final prefix =
           imports.putIfAbsent(library, () => generateUniqueName('p'));
       return '$prefix.$originalName';
     }
     return renamed[element] = generateUniqueName(originalName);
   }
 }