Applying late feedback on CL https://chromiumcodereview.appspot.com/10834051.

net/net.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
     'conditions': [
@@ skipping 1013 matching lines @@
             'link_settings': {
               'libraries': [
                 '$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
                 '$(SDKROOT)/System/Library/Frameworks/Security.framework',
                 '$(SDKROOT)/System/Library/Frameworks/SystemConfiguration.framework',
                 '$(SDKROOT)/usr/lib/libresolv.dylib',
               ]
             },
           },
         ],
-        [ 'OS == "android"', {
-            'defines': [
-              # Android can shut down our app at any time, so we persist session cookies.
-              'ENABLE_PERSISTENT_SESSION_COOKIES'
-            ],
-            'dependencies': [
-              '../third_party/openssl/openssl.gyp:openssl',
-              'net_jni_headers',
-            ],
-            'sources!': [
-              'base/openssl_memory_private_key_store.cc',
-            ],
-          }, {  # else OS! = "android"
-            'defines': [
-              # These are the features Android doesn't support.
-              'ENABLE_MEDIA_CODEC_THEORA',
-            ],
-          },
-        ],
-        [ 'OS == "linux"', {
-            'dependencies': [
-              '../build/linux/system.gyp:dbus',
-              '../dbus/dbus.gyp:dbus',
-            ],
-          },
-        ],
         [ 'OS == "ios"', {
             'link_settings': {
               'libraries': [
                 '$(SDKROOT)/System/Library/Frameworks/CFNetwork.framework',
                 '$(SDKROOT)/System/Library/Frameworks/MobileCoreServices.framework',
                 '$(SDKROOT)/System/Library/Frameworks/SystemConfiguration.framework',
                 '$(SDKROOT)/usr/lib/libresolv.dylib',
               ],
             },
             'sources/': [
@@ skipping 15 matching lines @@
               ['include', '^base/platform_mime_util\\.h$'],
               ['include', '^base/registry_controlled_domains/registry_controlled_domain\\.'],
               ['include', '^http/http_byte_range\\.'],
               ['include', '^http/http_content_disposition\\.'],
               ['include', '^http/http_util\\.'],
               ['include', '^http/http_util_icu\\.cc$'],
               ['include', '^http/http_version\\.h$'],
             ],
           },
         ],
+        [ 'OS == "android"', {
+            'defines': [
+              # Android can shut down our app at any time, so we persist session cookies.

[Ryan Sleevi, 2012/08/01 17:46:56]

not your fault, but...

style nit: Line wrapping
comment nit: Remove "we"

[noyau (Ping after 24h), 2012/08/02 09:56:38]

Done.

+              'ENABLE_PERSISTENT_SESSION_COOKIES'
+            ],
+            'dependencies': [
+              '../third_party/openssl/openssl.gyp:openssl',
+              'net_jni_headers',

[Ryan Sleevi, 2012/08/01 17:46:56]

nit: Just from looking at the other changes, '../' is sorted after the alphas
(eg: 1745 - 1749)

[noyau (Ping after 24h), 2012/08/02 09:56:38]

This is completely inconsistent in this file. '..' should be *before* the alpha,
it is for the 'net' target, for this one and some others. I've made it all
consistent.

+            ],
+            'sources!': [
+              'base/openssl_memory_private_key_store.cc',
+            ],
+          }, {  # else OS! = "android"
+            'defines': [
+              # These are the features Android doesn't support.
+              'ENABLE_MEDIA_CODEC_THEORA',
+            ],
+          },
+        ],
+        [ 'OS == "linux"', {
+            'dependencies': [
+              '../build/linux/system.gyp:dbus',
+              '../dbus/dbus.gyp:dbus',
+            ],
+          },
+        ],
       ],
       'target_conditions': [
         # These source files are excluded by default platform rules, but they
         # are needed in specific cases on other platforms. Re-including them can
         # only be done in target_conditions as it is evaluated after the
         # platform rules.
         ['OS == "android"', {
           'sources/': [
             ['include', '^base/platform_mime_util_linux\\.cc$'],
           ],
@@ skipping 336 matching lines @@
           },
         ],
         [ 'OS == "mac"', {
             'dependencies': [
               '../third_party/nss/nss.gyp:nspr',
               '../third_party/nss/nss.gyp:nss',
               'third_party/nss/ssl.gyp:libssl',
             ],
           },
         ],
+        ['OS == "ios"', {
+          # TODO: For now this only tests the subset of code that is enabled in
+          # the net target.
+          'dependencies': [
+            '../testing/gtest.gyp:gtest_main',
+          ],
+          'dependencies!': [
+            'net_test_support',
+          ],
+          'sources/': [
+            ['exclude', '.*'],
+            ['include', '^base/dns_util_unittest\\.cc$'],
+            ['include', '^base/escape_unittest\\.cc$'],
+            ['include', '^base/ip_endpoint_unittest\\.cc$'],
+            ['include', '^base/mime_util_unittest\\.cc$'],
+            ['include', '^base/net_log_unittest\\.cc$'],
+            ['include', '^base/registry_controlled_domains/registry_controlled_domain_unittest\\.cc$'],
+            ['include', '^http/http_byte_range_unittest\\.cc$'],
+            ['include', '^http/http_content_disposition_unittest\\.cc$'],
+            ['include', '^http/http_util_unittest\\.cc$'],
+          ],
+        }],
         [ 'OS == "linux"', {
             'dependencies': [
               '../build/linux/system.gyp:dbus',
               '../dbus/dbus.gyp:dbus_test_support',
             ],
           },
         ],
         [ 'OS == "android"', {
             'defines': [
               # Android can shut down our app at any time, so we persist session cookies.
@@ skipping 10 matching lines @@
         ['OS == "android" and gtest_target_type == "shared_library"', {
           'dependencies': [
             '../testing/android/native_test.gyp:native_test_native_code',
           ]
         }],
         [ 'OS != "win" and OS != "mac"', {
           'sources!': [
             'base/x509_cert_types_unittest.cc',
           ],
         }],
-        ['OS == "ios"', {
-          # TODO: For now this only tests the subset of code that is enabled in
-          # the net target.
-          'dependencies': [
-            '../testing/gtest.gyp:gtest_main',
-          ],
-          'dependencies!': [
-            'net_test_support',
-          ],
-          'sources/': [
-            ['exclude', '.*'],
-            ['include', '^base/dns_util_unittest\\.cc$'],
-            ['include', '^base/escape_unittest\\.cc$'],
-            ['include', '^base/ip_endpoint_unittest\\.cc$'],
-            ['include', '^base/mime_util_unittest\\.cc$'],
-            ['include', '^base/net_log_unittest\\.cc$'],
-            ['include', '^base/registry_controlled_domains/registry_controlled_domain_unittest\\.cc$'],
-            ['include', '^http/http_byte_range_unittest\\.cc$'],
-            ['include', '^http/http_content_disposition_unittest\\.cc$'],
-            ['include', '^http/http_util_unittest\\.cc$'],
-          ],
-        }],
       ],
     },
     {
       'target_name': 'net_perftests',
       'type': 'executable',
       'dependencies': [
         'net',
         'net_test_support',
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
@@ skipping 90 matching lines @@
         'test/remote_test_server.h',
         'test/spawner_communicator.cc',
         'test/spawner_communicator.h',
         'test/test_server.h',
         'url_request/test_url_fetcher_factory.cc',
         'url_request/test_url_fetcher_factory.h',
         'url_request/url_request_test_util.cc',
         'url_request/url_request_test_util.h',
       ],
       'conditions': [
         ['inside_chromium_build==1 and OS != "ios"', {

[noyau (Ping after 24h), 2012/07/31 15:29:57]

wtc said:
To be honest, I don't know. This was added in the ios tree and I parroted it
here. I'm guessing that as we don't compile nor use a test server on ios there
is no point for those dependencies anyway? But that's just an educated guess.

[stuartmorgan, 2012/07/31 17:47:47]

I haven't looked up the history, but it's certainly the case that we don't have
support yet for running a test server on the host machine and having a device
talk to that server.

It's unclear to me if the cloud_policy_codegen thing is related to the test
server though.

[Ryan Sleevi, 2012/07/31 17:54:29]

It is.  http://crbug.com/119403 is about fixing this. I thought upstream had a
bug annotation here that may not have been caught in the move.

It's listed here because the Python code unconditionally imports the generated
Python protobuf-generated code.

The 'inside_chromium_build' was to ensure that these dependencies don't exist
for Chromium-in-WebKit, since as it was mentioned elsewhere,
dependencies!/dependencies/ don't work for non-existinant GYP files.

           'dependencies': [
             '../chrome/app/policy/cloud_policy_codegen.gyp:cloud_policy_proto_compile',
             # The test server uses Python modules generated by the sync protos.
             '../sync/protocol/sync_proto.gyp:sync_proto',
             '../third_party/protobuf/protobuf.gyp:py_proto',
           ],
         }],
         ['os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', {
           'conditions': [
             ['use_openssl==1', {
@@ skipping 62 matching lines @@
         'server/web_socket.h',
       ],
     },
   ],
   'conditions': [
     ['OS != "ios"', {
       'targets': [
         # iOS doesn't have the concept of simple executables, these targets
         # can't be compiled on the platform.
         {
+          'target_name': 'crash_cache',
+          'type': 'executable',
+          'dependencies': [
+            'net',
+            'net_test_support',
+            '../base/base.gyp:base',
+          ],
+          'sources': [
+            'tools/crash_cache/crash_cache.cc',
+          ],
+        },
+        {
+          'target_name': 'crl_set_dump',
+          'type': 'executable',
+          'dependencies': [
+            'net',
+            '../base/base.gyp:base',
+          ],
+          'sources': [
+            'tools/crl_set_dump/crl_set_dump.cc',
+          ],
+        },
+        {
+          'target_name': 'dns_fuzz_stub',
+          'type': 'executable',
+          'dependencies': [
+            'net',
+            '../base/base.gyp:base',
+          ],
+          'sources': [
+            'tools/dns_fuzz_stub/dns_fuzz_stub.cc',
+          ],
+        },
+        {
           'target_name': 'dnssec_chain_verify',
           'type': 'executable',
           'dependencies': [
             'net',
             '../base/base.gyp:base',
           ],
           'sources': [
             'tools/dnssec_chain_verify/dnssec_chain_verify.cc',
           ],
         },
         {
+          'target_name': 'fetch_client',
+          'type': 'executable',
+          'variables': { 'enable_wexit_time_destructors': 1, },
+          'dependencies': [
+            'net',
+            '../base/base.gyp:base',
+            '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+            '../build/temp_gyp/googleurl.gyp:googleurl',
+            '../testing/gtest.gyp:gtest',
+          ],
+          'sources': [
+            'tools/fetch/fetch_client.cc',
+          ],
+        },
+        {
           'target_name': 'fetch_server',
           'type': 'executable',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             'net',
             '../base/base.gyp:base',
             '../build/temp_gyp/googleurl.gyp:googleurl',
           ],
           'sources': [
             'tools/fetch/fetch_server.cc',
@@ skipping 26 matching lines @@
           'type': 'executable',
           'dependencies': [
             'net',
             '../base/base.gyp:base',
           ],
           'sources': [
             'tools/net_watcher/net_watcher.cc',
           ],
         },
         {
-          'target_name': 'crl_set_dump',
+          'target_name': 'run_testserver',
           'type': 'executable',
           'dependencies': [
             'net',
+            'net_test_support',
             '../base/base.gyp:base',
+            '../build/temp_gyp/googleurl.gyp:googleurl',
+            '../testing/gtest.gyp:gtest',
           ],
           'sources': [
-            'tools/crl_set_dump/crl_set_dump.cc',
-          ],
-        },
-        {
-          'target_name': 'tld_cleanup',
-          'type': 'executable',
-          'dependencies': [
-            '../base/base.gyp:base',
-            '../base/base.gyp:base_i18n',
-            '../build/temp_gyp/googleurl.gyp:googleurl',
-          ],
-          'sources': [
-            'tools/tld_cleanup/tld_cleanup.cc',
-          ],
-        },
-        {
-          'target_name': 'dns_fuzz_stub',
-          'type': 'executable',
-          'dependencies': [
-            'net',
-            '../base/base.gyp:base',
-          ],
-          'sources': [
-            'tools/dns_fuzz_stub/dns_fuzz_stub.cc',
+            'tools/testserver/run_testserver.cc',
           ],
         },
         {
           'target_name': 'stress_cache',
           'type': 'executable',
           'dependencies': [
             'net',
             'net_test_support',
             '../base/base.gyp:base',
           ],
           'sources': [
             'disk_cache/stress_cache.cc',
           ],
         },
         {
-          'target_name': 'crash_cache',
+          'target_name': 'tld_cleanup',
           'type': 'executable',
           'dependencies': [
-            'net',
-            'net_test_support',
             '../base/base.gyp:base',
+            '../base/base.gyp:base_i18n',
+            '../build/temp_gyp/googleurl.gyp:googleurl',
           ],
           'sources': [
-            'tools/crash_cache/crash_cache.cc',
-          ],
-        },
-        {
-          'target_name': 'run_testserver',
-          'type': 'executable',
-          'dependencies': [
-            'net',
-            'net_test_support',
-            '../base/base.gyp:base',
-            '../build/temp_gyp/googleurl.gyp:googleurl',
-            '../testing/gtest.gyp:gtest',
-          ],
-          'sources': [
-            'tools/testserver/run_testserver.cc',
-          ],
-        },
-        {
-          'target_name': 'fetch_client',
-          'type': 'executable',
-          'variables': { 'enable_wexit_time_destructors': 1, },
-          'dependencies': [
-            'net',
-            '../base/base.gyp:base',
-            '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-            '../build/temp_gyp/googleurl.gyp:googleurl',
-            '../testing/gtest.gyp:gtest',
-          ],
-          'sources': [
-            'tools/fetch/fetch_client.cc',
+            'tools/tld_cleanup/tld_cleanup.cc',
           ],
         },
       ],
     }],
     ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {
       'targets': [
         {
           'target_name': 'flip_in_mem_edsm_server',
           'type': 'executable',
           'cflags': [
@@ skipping 224 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }