Update media galleries documentation.

Update media galleries documentation.

BUG=116025
NOTRY=TRUE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149139

[not at google - send to devlin, 2012-07-31 06:17:10]

lgtm

[commit-bot: I haz the power, 2012-07-31 06:22:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/10832079/1

[commit-bot: I haz the power, 2012-07-31 06:22:44]

Presubmit check for 10832079-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/mediaGalleries.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

[not at google - send to devlin, 2012-07-31 06:25:02]

That script has false positives (negatives? I can never remember the
difference), sometimes, so you'll need to submit manually. I think it might be
because it's a platform app API so there's no extension component, and the
presubmit check doesn't realise that.

Btw what's NOTRY mean?

[vandebo (ex-Chrome), 2012-07-31 06:30:12]

On 2012/07/31 06:25:02, kalman wrote:
> That script has false positives (negatives? I can never remember the
> difference), sometimes, so you'll need to submit manually. I think it might be
> because it's a platform app API so there's no extension component, and the
> presubmit check doesn't realise that.
> 
> Btw what's NOTRY mean?

NOTRY=TRUE tells the CQ that it's a non-code change and it doesn't need to run
try bots.

[battre, 2012-07-31 07:53:08]

On 2012/07/31 06:30:12, vandebo wrote:
> On 2012/07/31 06:25:02, kalman wrote:
> > That script has false positives (negatives? I can never remember the
> > difference), sometimes, so you'll need to submit manually. I think it might
be
> > because it's a platform app API so there's no extension component, and the
> > presubmit check doesn't realise that.
> > 
> > Btw what's NOTRY mean?
> 
> NOTRY=TRUE tells the CQ that it's a non-code change and it doesn't need to run
> try bots.

You did not update all files.
http://code.google.com/chrome/extensions/trunk/experimental.html still  links to
the experimental mediaGalleries file which does not exist any more.

[battre, 2012-07-31 08:00:02]

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/apps/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:205: currently trigger an
install time permission prompt because it requires
You cannot say "does not *currently* trigger an install time permission prompt".
If you release the api as is, you cannot add functions to the mediaGalleriesRead
permission that can open files without showing the file picker dialog.

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:208: You may also specify
the "mediaGalleriesAllGalleries" permission to get
This contradicts to the statement "only the 'mediaGalleriesRead' permission is
allowed"

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:338:
<span>LocalFileSystem</span>
Why is this no link? What is a LocalFileSystem object?

[vandebo (ex-Chrome), 2012-07-31 16:43:43]

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/apps/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:205: currently trigger an
install time permission prompt because it requires
On 2012/07/31 08:00:02, battre wrote:
> You cannot say "does not *currently* trigger an install time permission
prompt".
> If you release the api as is, you cannot add functions to the
mediaGalleriesRead
> permission that can open files without showing the file picker dialog.

Rephrased.

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:208: You may also specify
the "mediaGalleriesAllGalleries" permission to get
On 2012/07/31 08:00:02, battre wrote:
> This contradicts to the statement "only the 'mediaGalleriesRead' permission is
> allowed"

Rephrased.

https://chromiumcodereview.appspot.com/10832079/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/apps/mediaGalleries.html:338:
<span>LocalFileSystem</span>
On 2012/07/31 08:00:02, battre wrote:
> Why is this no link? What is a LocalFileSystem object?

It's not an extension object.  It refers to
http://www.w3.org/TR/file-system-api/

The extension documentation system doesn't seem to let me make that link.

[battre, 2012-08-01 12:43:44]

+asargent

Hi Antony,

is there a way to create a link for LocalFileSystem in the IDL file? (see last 2
mails in the discussion)

Best regards,
Dominic

[asargent_no_longer_on_chrome, 2012-08-01 16:31:52]

In theory it should work, but I don't think I've tried it yet. If it turns out
there are bugs I'd be happy to fix them. Offhand I'd guess a possible parsing
bug is not handling the "//" in the url properly and getting confused with the
comment delimiter, so as a workaround you might try dropping the "http://"
prefix.

[vandebo (ex-Chrome), 2012-08-01 18:38:20]

Following up with Antony, there's no current support to make the type clickable
(he's filled a bug), but we could add a comment with link/url.

[asargent_no_longer_on_chrome, 2012-08-01 18:48:01]

Filed as http://crbug.com/140071

BTW, it turns out you can get linkified comments if you don't use double quotes.
E.g.

// See the reference for <a href='http://whatever.com/Foo'>Foo</a> for more
details.
static void myfunc([instanceOf=Foo]object foo);