Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10832078: Add the user email field to Chrome. (Closed)

Created:
8 years, 4 months ago by rkc
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add the user email field to Chrome. Add the user email field for Chrome on all other platforms (ChromeOS already has it); also make the field editable. R=estade@chromium.org BUG=94149 TEST=Send feedback reports from all 4 platforms, from both incognito and regular modes, making sure that the user e-mail is populated correctly and reported to the Feedback server correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -56 lines) Patch
M chrome/browser/feedback/feedback_data.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/feedback.css View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/feedback.html View 4 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/resources/feedback.js View 2 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 9 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rkc
8 years, 4 months ago (2012-07-31 02:47:35 UTC) #1
Evan Stade
lgtm
8 years, 4 months ago (2012-07-31 19:00:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10832078/1
8 years, 4 months ago (2012-07-31 19:26:31 UTC) #3
commit-bot: I haz the power
Presubmit check for 10832078-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 19:26:36 UTC) #4
rkc
Since feedback doesn't have any owners right now, adding ben@ for the owners review. On ...
8 years, 4 months ago (2012-07-31 22:30:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10832078/1
8 years, 4 months ago (2012-08-01 00:00:40 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 01:25:27 UTC) #7
Change committed as 149346

Powered by Google App Engine
This is Rietveld 408576698