Issue 10832073: Only prelaunch the GPU process when accelerated compositor is not blacklisted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832073: Only prelaunch the GPU process when accelerated compositor is not blacklisted. (Closed)

Created:
8 years, 4 months ago by apatrick_chromium

Modified:
5 years, 6 months ago

Reviewers:
Zhenyao Mo, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Only prelaunch the GPU process when accelerated compositor is not blacklisted. BUG=139147

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/browser/browser_main_loop.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

https://chromiumcodereview.appspot.com/10832073/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://chromiumcodereview.appspot.com/10832073/diff/1/content/browser/browser_main_loop.cc#newcode445 content/browser/browser_main_loop.cc:445: gpu_data_manager->GetGpuFeatureType() == content::GPU_FEATURE_TYPE_ALL && != instead of ==

8 years, 4 months ago (2012-07-30 22:42:05 UTC) #2

apatrick_chromium

Are you sure I don't want == 0, i.e. no features are blacklisted?

8 years, 4 months ago (2012-07-30 22:47:34 UTC) #3

Zhenyao Mo

On 2012/07/30 22:53:57, apatrick_chromium wrote: > zmo tells me i want this. ptal. LGTM

8 years, 4 months ago (2012-07-30 22:55:56 UTC) #5

LGTM

Expand Messages | Collapse Messages

Issue 10832073: Only prelaunch the GPU process when accelerated compositor is not blacklisted. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages