Issue 10832065: Update path to data file in perf test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832065: Update path to data file in perf test (Closed)

Created:
8 years, 4 months ago by Nirnimesh

Modified:
8 years, 4 months ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update path to data file in perf test R=dennisjeffrey@chromium.org BUG=139651 TEST= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148993

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/test/functional/perf.py	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM with a follow-up question not to be addressed in this CL. https://chromiumcodereview.appspot.com/10832065/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py ...

8 years, 4 months ago (2012-07-30 18:55:20 UTC) #2

Nirnimesh

8 years, 4 months ago (2012-07-30 19:04:31 UTC) #3

On 2012/07/30 18:55:20, dennis_jeffrey wrote:
> LGTM with a follow-up question not to be addressed in this CL.
> 
>
https://chromiumcodereview.appspot.com/10832065/diff/1/chrome/test/functional...
> File chrome/test/functional/perf.py (right):
> 
>
https://chromiumcodereview.appspot.com/10832065/diff/1/chrome/test/functional...
> chrome/test/functional/perf.py:695: url =
> self.GetFileURLForContentDataPath('plugin', 'flash.swf')
> not for this CL, but would it be worthwhile changing the function names
> "DataDir" and "GetFileURLForDataPath" to "BrowserDataDir" and
> "GetFileURLForBrowserDataPath", respectively?

maybe... ChromeDataDir

Expand Messages | Collapse Messages