Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: utils/tests/pub/version_test.dart

Issue 10832058: Improved the way we generate mismatch descriptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/unittest/unittest_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/version_test.dart
===================================================================
--- utils/tests/pub/version_test.dart (revision 10002)
+++ utils/tests/pub/version_test.dart (working copy)
@@ -384,13 +384,14 @@
VersionConstraintMatcher(this._expected, this._allow);
- bool matches(item) => (item is VersionConstraint) &&
+ bool matches(item, MatchState matchState) => (item is VersionConstraint) &&
_expected.every((version) => item.allows(version) == _allow);
Description describe(Description description) =>
description.add(' ${_allow ? "allows" : "does not allow"} versions');
- Description describeMismatch(item, Description mismatchDescription) {
+ Description describeMismatch(item, Description mismatchDescription,
+ MatchState matchState, bool verbose) {
if (item is! VersionConstraint) {
mismatchDescription.add('was not a VersionConstraint');
return mismatchDescription;
« no previous file with comments | « tests/lib/unittest/unittest_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698