Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: lib/unittest/matcher.dart

Issue 10832058: Improved the way we generate mismatch descriptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/unittest/map_matchers.dart ('k') | lib/unittest/mock.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * MatchState is a simple wrapper around an arbitrary object.
7 * [Matcher] [matches] methods can use this to store useful
8 * information upon match failures, and this information will
9 * be passed to [describeMismatch]. Each [Matcher] is responsible
10 * for its own use of this state, so the state created by [matches]
11 * should be consistent with that expected by [describeMismatch] in
12 * the same [Matcher] class, but can vary between classes. The inner
13 * state, if set, will typically be a [Map] with a number of key-value
14 * pairs containing relevant state information.
15 */
16 class MatchState {
17 var state = null;
18
19 MatchState([this.state]);
20 }
21
22 /**
6 * BaseMatcher is the base class for all matchers. To implement a new 23 * BaseMatcher is the base class for all matchers. To implement a new
7 * matcher, either add a class that implements from IMatcher or 24 * matcher, either add a class that implements from IMatcher or
8 * a class that inherits from Matcher. Inheriting from Matcher has 25 * a class that inherits from Matcher. Inheriting from Matcher has
9 * the benefit that a default implementation of describeMismatch will 26 * the benefit that a default implementation of describeMismatch will
10 * be provided. 27 * be provided.
11 */ 28 */
12
13 class BaseMatcher implements Matcher { 29 class BaseMatcher implements Matcher {
14 const BaseMatcher(); 30 const BaseMatcher();
15 31
16 /** 32 /**
17 * Tests the matcher against a given [item] 33 * Tests the matcher against a given [item]
18 * and return true if the match succeeds; false otherwise. 34 * and return true if the match succeeds; false otherwise.
35 * [matchState] may be used to return additional info for
36 * the use of [describeMismatch].
19 */ 37 */
20 abstract bool matches(item); 38 abstract bool matches(item, MatchState matchState);
21 39
22 /** 40 /**
23 * Creates a textual description of a matcher, 41 * Creates a textual description of a matcher,
24 * by appending to [mismatchDescription]. 42 * by appending to [mismatchDescription].
25 */ 43 */
26 abstract Description describe(Description mismatchDescription); 44 abstract Description describe(Description mismatchDescription);
27 45
28 /** 46 /**
29 * Generates a description of the matcher failed for a particular 47 * Generates a description of the matcher failed for a particular
30 * [item], by appending the description to [mismatchDescription]. 48 * [item], by appending the description to [mismatchDescription].
31 * It does not check whether the [item] fails the match, as it is 49 * It does not check whether the [item] fails the match, as it is
32 * only called after a failed match. 50 * only called after a failed match. There may be additional info
51 * about the mismatch in [matchState].
33 */ 52 */
34 Description describeMismatch(item, Description mismatchDescription) => 53 Description describeMismatch(item, Description mismatchDescription,
54 MatchState matchState, bool verbose) =>
35 mismatchDescription.add('was ').addDescriptionOf(item); 55 mismatchDescription.add('was ').addDescriptionOf(item);
36 } 56 }
OLDNEW
« no previous file with comments | « lib/unittest/map_matchers.dart ('k') | lib/unittest/mock.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698