Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: lib/unittest/map_matchers.dart

Issue 10832058: Improved the way we generate mismatch descriptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/unittest/interfaces.dart ('k') | lib/unittest/matcher.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Returns a matcher which matches maps containing the given [value]. 6 * Returns a matcher which matches maps containing the given [value].
7 */ 7 */
8 Matcher containsValue(value) => new _ContainsValue(value); 8 Matcher containsValue(value) => new _ContainsValue(value);
9 9
10 class _ContainsValue extends BaseMatcher { 10 class _ContainsValue extends BaseMatcher {
11 final _value; 11 final _value;
12 12
13 const _ContainsValue(this._value); 13 const _ContainsValue(this._value);
14 14
15 bool matches(item) => item.containsValue(_value); 15 bool matches(item, MatchState matchState) => item.containsValue(_value);
16 Description describe(Description description) => 16 Description describe(Description description) =>
17 description.add('contains value ').addDescriptionOf(_value); 17 description.add('contains value ').addDescriptionOf(_value);
18 } 18 }
19 19
20 /** 20 /**
21 * Returns a matcher which matches maps containing the key-value pair 21 * Returns a matcher which matches maps containing the key-value pair
22 * with [key] => [value]. 22 * with [key] => [value].
23 */ 23 */
24 Matcher containsPair(key, value) => 24 Matcher containsPair(key, value) =>
25 new _ContainsMapping(key, wrapMatcher(value)); 25 new _ContainsMapping(key, wrapMatcher(value));
26 26
27 class _ContainsMapping extends BaseMatcher { 27 class _ContainsMapping extends BaseMatcher {
28 final _key; 28 final _key;
29 final Matcher _valueMatcher; 29 final Matcher _valueMatcher;
30 30
31 const _ContainsMapping(this._key, Matcher this._valueMatcher); 31 const _ContainsMapping(this._key, Matcher this._valueMatcher);
32 32
33 bool matches(item) => 33 bool matches(item, MatchState matchState) =>
34 item.containsKey(_key) && _valueMatcher.matches(item[_key]); 34 item.containsKey(_key) &&
35 _valueMatcher.matches(item[_key], matchState);
35 36
36 Description describe(Description description) { 37 Description describe(Description description) {
37 return description.add('contains pair ').addDescriptionOf(_key). 38 return description.add('contains pair ').addDescriptionOf(_key).
38 add(' => ').addDescriptionOf(_valueMatcher); 39 add(' => ').addDescriptionOf(_valueMatcher);
39 } 40 }
40 41
41 Description describeMismatch(item, Description mismatchDescription) { 42 Description describeMismatch(item, Description mismatchDescription,
43 MatchState matchState, bool verbose) {
42 if (!item.containsKey(_key)) { 44 if (!item.containsKey(_key)) {
43 return mismatchDescription.addDescriptionOf(item). 45 return mismatchDescription.addDescriptionOf(item).
44 add(" doesn't contain key ").addDescriptionOf(_key); 46 add(" doesn't contain key ").addDescriptionOf(_key);
45 } else { 47 } else {
46 mismatchDescription.add(' contains key ').addDescriptionOf(_key). 48 mismatchDescription.add(' contains key ').addDescriptionOf(_key).
47 add(' but with value '); 49 add(' but with value ');
48 _valueMatcher.describeMismatch(item[_key], mismatchDescription); 50 _valueMatcher.describeMismatch(item[_key], mismatchDescription,
51 matchState, verbose);
49 return mismatchDescription; 52 return mismatchDescription;
50 } 53 }
51 } 54 }
52 } 55 }
OLDNEW
« no previous file with comments | « lib/unittest/interfaces.dart ('k') | lib/unittest/matcher.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698