Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 10832052: [Mac]: Change rename/add bookmark folder dialog buttons' text to "Save" and "Add" respectively. (Closed)

Created:
8 years, 4 months ago by Alexei Svitkine (slow)
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac]: Change rename/add bookmark folder dialog buttons' text to "Save" and "Add" respectively. Also removes a no-longer necessary -respondsToSelect: check since we no longer support 10.5. BUG=20053 TEST=Right click on a BMB folder and click edit. Buttons should be "Cancel" and "Save". Right click on BMB and select "Add Folder...". Buttons should be "Cancel" and "Add". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148851

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 1 chunk +3 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
8 years, 4 months ago (2012-07-27 22:10:43 UTC) #1
Nico
https://chromiumcodereview.appspot.com/10832052/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm (right): https://chromiumcodereview.appspot.com/10832052/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm#newcode76 chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm:76: IDS_ADD)]; Why not change the nib instead?
8 years, 4 months ago (2012-07-27 22:25:20 UTC) #2
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/10832052/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm (right): https://chromiumcodereview.appspot.com/10832052/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm#newcode76 chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm:76: IDS_ADD)]; On 2012/07/27 22:25:20, Nico wrote: > Why not ...
8 years, 4 months ago (2012-07-27 22:32:01 UTC) #3
Nico
lgtm
8 years, 4 months ago (2012-07-27 22:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10832052/1
8 years, 4 months ago (2012-07-27 22:34:49 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 23:50:56 UTC) #6
Change committed as 148851

Powered by Google App Engine
This is Rietveld 408576698