Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 10832046: [chromeos] Simplify ephemeral users tests (Closed)

Created:
8 years, 5 months ago by Nirnimesh
Modified:
8 years, 4 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

[chromeos] Simplify ephemeral users tests Now that /root/.forget_usernames is gone, remove the hacks from chromeos_ephemeral.py BUG=None TEST=chromeos_ephemeral.py NOTRY=true R=bartfab@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148730

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -55 lines) Patch
M chrome/test/functional/chromeos_ephemeral.py View 6 chunks +6 lines, -55 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
Nirnimesh
I'll get around to removing the actual calls (like: TryToEnableLocalStateAutoClearingOnChromeOS) after I remove it from ...
8 years, 5 months ago (2012-07-27 01:26:13 UTC) #1
bartfab (slow)
One question, otherwise LGTM. http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeos_ephemeral.py File chrome/test/functional/chromeos_ephemeral.py (left): http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeos_ephemeral.py#oldcode114 chrome/test/functional/chromeos_ephemeral.py:114: self.set_clear_profile(False) Is this no longer ...
8 years, 4 months ago (2012-07-27 08:11:22 UTC) #2
Nirnimesh
http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeos_ephemeral.py File chrome/test/functional/chromeos_ephemeral.py (left): http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeos_ephemeral.py#oldcode114 chrome/test/functional/chromeos_ephemeral.py:114: self.set_clear_profile(False) Logout() does not clear user profile (/home/chronos/user). "Local ...
8 years, 4 months ago (2012-07-27 08:24:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10832046/1
8 years, 4 months ago (2012-07-27 08:25:11 UTC) #4
commit-bot: I haz the power
Change committed as 148730
8 years, 4 months ago (2012-07-27 08:25:18 UTC) #5
bartfab (slow)
8 years, 4 months ago (2012-07-27 08:28:39 UTC) #6
http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeo...
File chrome/test/functional/chromeos_ephemeral.py (left):

http://codereview.chromium.org/10832046/diff/1/chrome/test/functional/chromeo...
chrome/test/functional/chromeos_ephemeral.py:114: self.set_clear_profile(False)
There is a set_clear_profile()/get_clear_profile() combo that, when set, would
cause __SetUp() to clear the user's profile. But I see now that as you say,
Logout() actually clears the flag before doing anything, so clearing it
ourselves is unnecessary. Perfect. Thanks for clarifying.

Powered by Google App Engine
This is Rietveld 408576698