Issue 10832045: Change talloc.c to build with the mac 10.7 SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832045: Change talloc.c to build with the mac 10.7 SDK (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Mark Mentovai, Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change talloc.c to build with the mac 10.7 SDK talloc.c has a local diff to define strnlen(), instead of using the definition in replace.c. However, the 10.7 SDK has its own strnlen(), which makes the compiler complain about a strnlen() redefinition. Use the pattern from replace.c to fix the redefinition problem. With this change, 'browser_tests' builds with the 10.7 SDK. BUG=136844 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148685

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/talloc/chromium.patch	View		1 chunk	+2 lines, -1 line	1 comment	Download
	M	third_party/talloc/talloc.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

8 years, 4 months ago (2012-07-27 01:10:14 UTC) #3

https://chromiumcodereview.appspot.com/10832045/diff/1/third_party/talloc/chr...
File third_party/talloc/chromium.patch (right):

https://chromiumcodereview.appspot.com/10832045/diff/1/third_party/talloc/chr...
third_party/talloc/chromium.patch:258: + static size_t rep_strnlen(const char*
s, size_t n)
Bet you broke this patch.

Expand Messages | Collapse Messages