Enhance GPU blacklist so we can also blacklist GPUs other than the primary one.

Enhance GPU blacklist so we can also blacklist GPUs other than the primary one.

For example, on Macbook, we can blacklist Intel HD 4000 whether it is the only GPU on the machine, or it is the integrated one of a dual GPU setting.

BUG=134015
TEST=unit_tests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148999

[Zhenyao Mo, 2012-07-27 00:45:30]

Please review.

[Ken Russell (switch to Gerrit), 2012-07-27 01:32:52]

https://chromiumcodereview.appspot.com/10832044/diff/1/chrome/browser/gpu_bla...
File chrome/browser/gpu_blacklist.cc (right):

https://chromiumcodereview.appspot.com/10832044/diff/1/chrome/browser/gpu_bla...
chrome/browser/gpu_blacklist.cc:805: multi_gpu_category_ ==
kMultiGpuCategoryPrimary)
This logic and that below is getting really difficult to follow. It isn't
obvious to me that it's correct any more. In particular, I'm not sure that if
the multi_gpu_category_ is Any, and the device ID matches but the vendor
doesn't, that it does the right thing. Sorry, but I think this needs to be
rewritten at this point.

It would be really nice if the secondary GPUs weren't in a separate list, so you
could just iterate down all the GPUs uniformly. The first GPU in the list would
implicitly be the primary one. That should simplify the logic considerably.
Please try that.

[Zhenyao Mo, 2012-07-27 23:50:21]

Revised.  Hope the logic is much clearer now.  Please have another look.

[Zhenyao Mo, 2012-07-30 18:48:55]

Ken, please have a look when you have time.

[Ken Russell (switch to Gerrit), 2012-07-30 19:13:52]

Thanks for the update and sorry for the delay. LGTM; one request for an
additional test.

https://chromiumcodereview.appspot.com/10832044/diff/10001/chrome/browser/gpu...
File chrome/browser/gpu_blacklist_unittest.cc (right):

https://chromiumcodereview.appspot.com/10832044/diff/10001/chrome/browser/gpu...
chrome/browser/gpu_blacklist_unittest.cc:873: TEST_F(GpuBlacklistTest,
MultipleGPUs) {
Please add one more test which verifies the multi_gpu_category of "secondary".

[Zhenyao Mo, 2012-07-30 19:35:12]

http://codereview.chromium.org/10832044/diff/10001/chrome/browser/gpu_blackli...
File chrome/browser/gpu_blacklist_unittest.cc (right):

http://codereview.chromium.org/10832044/diff/10001/chrome/browser/gpu_blackli...
chrome/browser/gpu_blacklist_unittest.cc:873: TEST_F(GpuBlacklistTest,
MultipleGPUs) {
On 2012/07/30 19:13:52, kbr wrote:
> Please add one more test which verifies the multi_gpu_category of "secondary".

Done.