Issue 10832029: Substitution implemented for the class hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832029: Substitution implemented for the class hierarchy. (Closed)

Created:
8 years, 4 months ago by Johnni Winther

Modified:
8 years, 4 months ago

Reviewers:
ahe, floitsch, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Substitution implemented for the class hierarchy.

Patch Set 1 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -60 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	1 chunk	+31 lines, -2 lines	1 comment	Download
M	lib/compiler/implementation/resolver.dart	View	7 chunks	+52 lines, -21 lines	0 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	5 chunks	+116 lines, -4 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View	2 chunks	+32 lines, -31 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

8 years, 4 months ago (2012-07-26 11:14:40 UTC) #2

FYI.

https://chromiumcodereview.appspot.com/10832029/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10832029/diff/2001/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:862: if (type === null) {
no need to === anymore. == is enough.

Expand Messages | Collapse Messages