Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7332)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 10832027: Only show load warnings for extensions under development. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 6bbd86f635e54858d1ad958d5c744e65aed8d016..9146c2ef3e730d31d2e1b0852f0c14cb42c13f65 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -192,19 +192,21 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
}
// Add install warnings (these are not the same as warnings!).
- const Extension::InstallWarningVector& install_warnings =
- extension->install_warnings();
- if (!install_warnings.empty()) {
- scoped_ptr<ListValue> list(new ListValue());
- for (Extension::InstallWarningVector::const_iterator it =
- install_warnings.begin(); it != install_warnings.end(); ++it) {
- DictionaryValue* item = new DictionaryValue();
- item->SetBoolean("isHTML",
- it->format == Extension::InstallWarning::FORMAT_HTML);
- item->SetString("message", it->message);
- list->Append(item);
+ if (extension->location() == Extension::LOAD) {
+ const Extension::InstallWarningVector& install_warnings =
+ extension->install_warnings();
+ if (!install_warnings.empty()) {
+ scoped_ptr<ListValue> list(new ListValue());
+ for (Extension::InstallWarningVector::const_iterator it =
+ install_warnings.begin(); it != install_warnings.end(); ++it) {
+ DictionaryValue* item = new DictionaryValue();
+ item->SetBoolean("isHTML",
+ it->format == Extension::InstallWarning::FORMAT_HTML);
+ item->SetString("message", it->message);
+ list->Append(item);
+ }
+ extension_data->Set("installWarnings", list.release());
}
- extension_data->Set("installWarnings", list.release());
}
return extension_data;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698