Issue 10832009: Additional checks/calls for cases when WebUI may be already gone but OOBE screen instance is not

Issue 10832009: Additional checks/calls for cases when WebUI may be already gone but OOBE screen instance is not (Closed)

Created:
8 years, 5 months ago by Nikita (slow)

Modified:
8 years, 5 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Additional checks/calls for cases when WebUI may be already gone but OOBE screen instance is not. BUG=chromium-os:32901 TEST=bvt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148522

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -24 lines)			Patch
M	chrome/browser/chromeos/login/eula_screen.cc	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_network_screen.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/mock_network_screen.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.cc	View		6 chunks	+25 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen_actor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/update_screen.cc	View		6 chunks	+18 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

Ivan Korotkov

LGTM I guess we should consider refactoring all these actor pointers to WeakPtr's

8 years, 5 months ago (2012-07-25 15:57:51 UTC) #2

Nikita (slow)

On 2012/07/25 15:57:51, Ivan Korotkov wrote: > LGTM > I guess we should consider refactoring ...

8 years, 5 months ago (2012-07-25 15:59:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10832009/1

8 years, 5 months ago (2012-07-25 17:35:30 UTC) #4

commit-bot: I haz the power

Try job failure for 10832009-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...

8 years, 5 months ago (2012-07-25 18:08:44 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10832009/1

8 years, 5 months ago (2012-07-25 18:09:49 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10832009/9004

8 years, 5 months ago (2012-07-26 01:00:33 UTC) #7

Change committed as 148522