Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10832002: gdata: Upload locally modified file in the correct size. (Closed)

Created:
8 years, 5 months ago by kinaba
Modified:
8 years, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Upload locally modified file in the correct size. This CL is the part 1 (of 2) for fixing 138512. Makes file uploder to refer to the actual size of the cache file, not the possibly out-of-sync metadata in GDataEntry. BUG=138512 TEST=UpdateFileByResourceId_PersistentFile TEST=Manual: - edit a file by photo editor and save as a different file. - verify the full content of the edited file is upload even if feed update intervenes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148497

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove an unused function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 3 chunks +52 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
8 years, 5 months ago (2012-07-25 05:42:22 UTC) #1
satorux1
LGTM with a nit: http://codereview.chromium.org/10832002/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc File chrome/browser/chromeos/gdata/gdata_file_system.cc (right): http://codereview.chromium.org/10832002/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc#newcode610 chrome/browser/chromeos/gdata/gdata_file_system.cc:610: void RunGetEntryInfoWithFilePathCallback( this seems to ...
8 years, 5 months ago (2012-07-25 19:07:14 UTC) #2
kinaba
http://codereview.chromium.org/10832002/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc File chrome/browser/chromeos/gdata/gdata_file_system.cc (right): http://codereview.chromium.org/10832002/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc#newcode610 chrome/browser/chromeos/gdata/gdata_file_system.cc:610: void RunGetEntryInfoWithFilePathCallback( On 2012/07/25 19:07:14, satorux1 wrote: > this ...
8 years, 5 months ago (2012-07-26 01:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10832002/5
8 years, 5 months ago (2012-07-26 01:30:08 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 02:40:39 UTC) #5
Change committed as 148497

Powered by Google App Engine
This is Rietveld 408576698