Source/modules/push_messaging/PushManager.idl - Issue 1083193006: Rename hasPermission to permissionState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushManager.idl

Issue 1083193006: Rename hasPermission to permissionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-add hasPermission to the expectations file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/push_messaging/PushManager.idl

diff --git a/Source/modules/push_messaging/PushManager.idl b/Source/modules/push_messaging/PushManager.idl

index b925cf14b424a0efbd9f313588b3e73da259a3ba..66f4c46700675a07843df9e4b2e0969acbce1aa2 100644

--- a/Source/modules/push_messaging/PushManager.idl

+++ b/Source/modules/push_messaging/PushManager.idl

@@ -11,5 +11,8 @@

] interface PushManager {

[CallWith=ScriptState] Promise<PushSubscription> subscribe();

[CallWith=ScriptState] Promise<PushSubscription?> getSubscription();

+ [RuntimeEnabled=PushMessagingHasPermission,CallWith=ScriptState] Promise permissionState();

+ // temporarily enabled as well for three sided patch

[RuntimeEnabled=PushMessagingHasPermission,CallWith=ScriptState] Promise hasPermission();

};