LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html - Issue 1083193006: Rename hasPermission to permissionState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html

Issue 1083193006: Rename hasPermission to permissionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-add hasPermission to the expectations file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/permission-state-granted-in-document.html ('k') | LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html

diff --git a/LayoutTests/http/tests/push_messaging/has-permission-granted-in-service-worker.html b/LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html

similarity index 74%

rename from LayoutTests/http/tests/push_messaging/has-permission-granted-in-service-worker.html

rename to LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html

index c9bbb4e97134579c9e72f037ed9c573268704946..1d25f6708c4543d4bf6d5ff9b6283f796de17c40 100644

--- a/LayoutTests/http/tests/push_messaging/has-permission-granted-in-service-worker.html

+++ b/LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html

@@ -2,7 +2,7 @@

<html>

<head>

<title>

- hasPermission when called in service worker resolves with granted when permission is granted

+ permissionState when called in service worker resolves with granted when permission is granted

</title>

@@ -21,21 +21,21 @@ async_test(function(test) {

var scope = 'resources/scope/' + location.pathname;

getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {

- workerInfo.port.postMessage({command: 'hasPermission'});

+ workerInfo.port.postMessage({command: 'permissionState'});

workerInfo.port.addEventListener('message', function(event) {

if (typeof event.data != 'object' || !event.data.command)

assert_unreached('Invalid message from the service worker');

- assert_equals(event.data.command, 'hasPermission');

+ assert_equals(event.data.command, 'permissionState');

assert_true(event.data.success,

- 'hasPermission should succeed. Error message: ' + event.data.errorMessage);

+ 'permissionState should succeed. Error message: ' + event.data.errorMessage);

assert_equals(event.data.permission, 'granted');

test.done();

});

}).catch(unreached_rejection(test));

-}, 'hasPermission when called in service worker resolves with granted when permission is granted');

+}, 'permissionState when called in service worker resolves with granted when permission is granted');

</script>

</body>

</html>