LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html - Issue 1083193006: Rename hasPermission to permissionState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html

Issue 1083193006: Rename hasPermission to permissionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-add hasPermission to the expectations file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/interfaces.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-default-in-service-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html

diff --git a/LayoutTests/http/tests/push_messaging/has-permission-default-in-document.html b/LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html

similarity index 80%

rename from LayoutTests/http/tests/push_messaging/has-permission-default-in-document.html

rename to LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html

index 88cd9e04945f4617fd29e40fae3ff8f3c2d05fd4..7d264b631e80b59eba2e72d0f8f9d0e07c600d5f 100644

--- a/LayoutTests/http/tests/push_messaging/has-permission-default-in-document.html

+++ b/LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<head>

-<title>Push API: hasPermission resolves with default when no permission is set</title>

+<title>Push API: permissionState resolves with default when no permission is set</title>

@@ -18,14 +18,14 @@ async_test(function(test) {

service_worker_unregister_and_register(test, workerUrl, workerScope)

.then(function(serviceWorkerRegistration) {

// If running manually, clear permissions before running this test.

- return serviceWorkerRegistration.pushManager.hasPermission();

+ return serviceWorkerRegistration.pushManager.permissionState();

})

.then(function(permissionStatus) {

assert_equals(permissionStatus, 'default');

return service_worker_unregister_and_done(test, workerScope);

})

.catch(unreached_rejection(test));

-}, 'Push API: hasPermission resolves with default when permission is not set');

+}, 'Push API: permissionState() resolves with default when permission is not set');

</script>

</body>

</html>