LayoutTests/http/tests/push_messaging/interfaces.html - Issue 1083193006: Rename hasPermission to permissionState.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/push_messaging/interfaces.html

Issue 1083193006: Rename hasPermission to permissionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-add hasPermission to the expectations file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/has-permission-granted-in-service-worker.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Push API: Verifies that the right Push API interfaces get exposed.</t itle>	4 <title>Push API: Verifies that the right Push API interfaces get exposed.</t itle>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 </head>	8 </head>

9 <body>	9 <body>

10 <script>	10 <script>

11 // Tests that the expected Push API interfaces are being exposed on both	11 // Tests that the expected Push API interfaces are being exposed on both

12 // the Service Worker and Document global scopes.	12 // the Service Worker and Document global scopes.

13 service_worker_test(	13 service_worker_test(

14 'resources/interfaces-worker.js',	14 'resources/interfaces-worker.js',

15 'Exposure of interfaces in a Service Worker.');	15 'Exposure of interfaces in a Service Worker.');

16	16

17 test(function() {	17 test(function() {

18 assert_own_property(self, 'PushManager', 'PushManager needs to be expo sed as a global.');	18 assert_own_property(self, 'PushManager', 'PushManager needs to be expo sed as a global.');

19	19

20 assert_own_property(PushManager.prototype, 'subscribe');	20 assert_own_property(PushManager.prototype, 'subscribe');

21 assert_own_property(PushManager.prototype, 'getSubscription');	21 assert_own_property(PushManager.prototype, 'getSubscription');

22 assert_own_property(PushManager.prototype, 'hasPermission');	22 assert_own_property(PushManager.prototype, 'permissionState');

23	23

24 }, 'PushManager should be exposed and have the expected interface in a Doc ument.');	24 }, 'PushManager should be exposed and have the expected interface in a Doc ument.');

25	25

26 test(function() {	26 test(function() {

27 assert_own_property(self, 'PushSubscription', 'PushSubscription needs to be exposed as a global.');	27 assert_own_property(self, 'PushSubscription', 'PushSubscription needs to be exposed as a global.');

28	28

29 // FIXME: Assert existence of the attributes when they are properly	29 // FIXME: Assert existence of the attributes when they are properly

30 // exposed in the prototype chain. https://crbug.com/43394	30 // exposed in the prototype chain. https://crbug.com/43394

31	31

32 assert_own_property(PushSubscription.prototype, 'unsubscribe');	32 assert_own_property(PushSubscription.prototype, 'unsubscribe');

33	33

34 }, 'PushSubscription should be exposed and have the expected interface in a Document.');	34 }, 'PushSubscription should be exposed and have the expected interface in a Document.');

35 </script>	35 </script>

36 </body>	36 </body>

37 </html>	37 </html>

OLD	NEW