src/objects.cc - Issue 10831409: Fix rounding in Uint8ClampedArray setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 10831409: Fix rounding in Uint8ClampedArray setter. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix manual rounding Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 64f5a452d7c74ae961b6af3ec44a48d981f30fd1..9306eb9a4d16418ae2127ed7dbf5a274581ccaf4 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -11628,7 +11628,7 @@ Object* ExternalPixelArray::SetValue(uint32_t index, Object* value) {

clamped_value = 255;

} else {

// Other doubles are rounded to the nearest integer.

- clamped_value = static_cast<uint8_t>(double_value + 0.5);

+ clamped_value = static_cast<uint8_t>(lrint(double_value));

}

} else {

// Clamp undefined to zero (default). All other types have been

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/platform.h » ('j') | no next file with comments »