src/ia32/macro-assembler-ia32.cc - Issue 10831409: Fix rounding in Uint8ClampedArray setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 10831409: Fix rounding in Uint8ClampedArray setter. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 83aef7801a70bc663815a9270b61eb5b9df33af1..e81144a244abccd94fcf33c0f5d243dfda03dcd1 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -134,10 +134,7 @@ void MacroAssembler::ClampDoubleToUint8(XMMRegister input_reg,

Set(result_reg, Immediate(0));

ucomisd(input_reg, scratch_reg);

j(below, &done, Label::kNear);

- ExternalReference half_ref = ExternalReference::address_of_one_half();

- movdbl(scratch_reg, Operand::StaticVariable(half_ref));

- addsd(scratch_reg, input_reg);

- cvttsd2si(result_reg, Operand(scratch_reg));

+ cvtsd2si(result_reg, input_reg);

test(result_reg, Immediate(0xFFFFFF00));

j(zero, &done, Label::kNear);

Set(result_reg, Immediate(255));