Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 10831396: Remove transitional WEBLAYER_IS_PURE_VIRTUAL code (Closed)

Created:
8 years, 4 months ago by jamesr
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer
Visibility:
Public.

Description

Remove transitional WEBLAYER_IS_PURE_VIRTUAL code The code guarded by !defined(WEBLAYER_IS_PURE_VIRTUAL) is dead as of http://trac.webkit.org/changeset/126076. Also removes WEBCONTENTLAYERCLIENT_FLOAT_OPAQUE_RECT code, which has been dead since WebKit r108829 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153132

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -249 lines) Patch
M ui/compositor/compositor.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 1 3 chunks +0 lines, -21 lines 0 comments Download
M ui/compositor/layer.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ui/compositor/layer.cc View 1 23 chunks +0 lines, -158 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 7 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
I'll send tryjobs out after that WebKit revision rolls in to DEPS.
8 years, 4 months ago (2012-08-20 22:15:40 UTC) #1
piman
LGTM, thanks!
8 years, 4 months ago (2012-08-20 22:36:30 UTC) #2
jamesr
WebKit patch re-landed at http://trac.webkit.org/changeset/126378. I'll rebase this and send tryjobs after it rolls in ...
8 years, 4 months ago (2012-08-23 01:45:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10831396/5001
8 years, 4 months ago (2012-08-23 22:32:47 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 00:54:46 UTC) #5
Change committed as 153132

Powered by Google App Engine
This is Rietveld 408576698