src/api.cc - Issue 10831388: Handle native callbacks without getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 10831388: Handle native callbacks without getters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed elements case, too. Rebased. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index b3cb3531cf8b4df2741c150eab75c41e2b13a271..c8a9e90821a1ced337c8b3ddfed526f7c6cfc69f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1067,7 +1067,6 @@ static i::Handle<i::AccessorInfo> MakeAccessorInfo(

v8::PropertyAttribute attributes,

v8::Handle<AccessorSignature> signature) {

i::Handle<i::AccessorInfo> obj = FACTORY->NewAccessorInfo();

- ASSERT(getter != NULL);

SET_FIELD_WRAPPED(obj, set_getter, getter);

SET_FIELD_WRAPPED(obj, set_setter, setter);

if (data.IsEmpty()) data = v8::Undefined();

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »