Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 10831381: Change Android build configurations (step 3). (Closed)

Created:
8 years, 4 months ago by Xianzhu
Modified:
8 years, 4 months ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Visibility:
Public.

Description

Change Android build configurations (step 3). Step 1 is https://chromiumcodereview.appspot.com/10827273/ which changed Debug build to build size-optimized code with DCHECK. Step 2 is https://chromiumcodereview.appspot.com/10836323/ which updated developer scripts and buildbot scripts to support the new configurations. Step 3: change Release configuration to no DCHECK and change default configuration to Debug. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152504

Patch Set 1 #

Patch Set 2 : Add android_full_debug variable #

Total comments: 4

Patch Set 3 : for landing #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M build/android/buildbot_functions.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/gdb_apk View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/test_options_parser.py View 1 chunk +5 lines, -4 lines 0 comments Download
M build/common.gypi View 1 2 3 4 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
8 years, 4 months ago (2012-08-17 22:57:23 UTC) #1
Torne
lgtm
8 years, 4 months ago (2012-08-20 10:23:02 UTC) #2
Satish
lgtm https://chromiumcodereview.appspot.com/10831381/diff/3001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10831381/diff/3001/build/common.gypi#newcode851 build/common.gypi:851: # Whether to build full debug version for ...
8 years, 4 months ago (2012-08-20 11:30:36 UTC) #3
Xianzhu
https://chromiumcodereview.appspot.com/10831381/diff/3001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10831381/diff/3001/build/common.gypi#newcode851 build/common.gypi:851: # Whether to build full debug version for Debug ...
8 years, 4 months ago (2012-08-20 18:12:43 UTC) #4
Xianzhu
Will land this after landing https://chromiumcodereview.appspot.com/10836323/ (step 2) and https://chromiumcodereview.appspot.com/10823400/ (v8 DEBUG)
8 years, 4 months ago (2012-08-20 20:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10831381/8002
8 years, 4 months ago (2012-08-21 01:28:42 UTC) #6
Xianzhu
On 2012/08/21 01:28:42, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 4 months ago (2012-08-21 01:29:08 UTC) #7
commit-bot: I haz the power
Change committed as 152504
8 years, 4 months ago (2012-08-21 04:39:01 UTC) #8
Isaac (away)
8 years, 4 months ago (2012-08-23 19:52:28 UTC) #9
Please try to CC me on all future CLs that modify buildbot_functions.sh.  This
CL silently broke all of our FYI for the last 5 days.

Powered by Google App Engine
This is Rietveld 408576698