Issue 10831374: Have component updater send a "wow64=1" parameter, to be able

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831374: Have component updater send a "wow64=1" parameter, to be able (Closed)

Created:
8 years, 4 months ago by jvoung (off chromium)

Modified:
8 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Have component updater send a "wow64=1" parameter, to be able to tell when the windows platform is 64-bit. PNaCl needs to use 64-bit nexes in that case, even if chrome is 32-bit. Retry of: http://codereview.chromium.org/10834348/ but this time with baseurl... BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365 TBR=cpu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152161

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/component_updater/component_updater_configurator.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/component_updater/pnacl/pnacl_component_installer.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

jvoung (off chromium)

ack... had to re-upload to a different CL/issue# since the baseurl didn't get set last ...

8 years, 4 months ago (2012-08-17 16:41:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/10831374/1

8 years, 4 months ago (2012-08-17 16:54:52 UTC) #2

Change committed as 152161