Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/ui/browser.cc

Issue 10831372: Revert 152080 - Refactor browser window zoom handling and enable zoom icon on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
===================================================================
--- chrome/browser/ui/browser.cc (revision 152086)
+++ chrome/browser/ui/browser.cc (working copy)
@@ -143,7 +143,6 @@
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/browser/ui/window_sizer/window_sizer.h"
-#include "chrome/browser/ui/zoom/zoom_controller.h"
#include "chrome/browser/upgrade_detector.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_constants.h"
@@ -1766,10 +1765,21 @@
///////////////////////////////////////////////////////////////////////////////
// Browser, ZoomObserver implementation:
-void Browser::OnZoomChanged(TabContents* source, bool can_show_bubble) {
+void Browser::OnZoomIconChanged(TabContents* source,
+ ZoomController::ZoomIconState state) {
+ if (source == chrome::GetActiveTabContents(this))
+ window_->SetZoomIconState(state);
+}
+
+void Browser::OnZoomChanged(TabContents* source,
+ int zoom_percent,
+ bool can_show_bubble) {
if (source == chrome::GetActiveTabContents(this)) {
+ window_->SetZoomIconTooltipPercent(zoom_percent);
+
// Only show the zoom bubble for zoom changes in the active window.
- window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive());
+ if (can_show_bubble && window_->IsActive())
+ window_->ShowZoomBubble(zoom_percent);
}
}
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698