Issue 10831363: Remove unnecessary gdata::, fix typos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831363: Remove unnecessary gdata::, fix typos. (Closed)

Created:
8 years, 4 months ago by kochi

Modified:
8 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary gdata::, fix typos. BUG=none TEST=compile succeeds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152069

Patch Set 2 : Fix for comment. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
M	chrome/browser/chromeos/gdata/drive_task_executor.cc	View		4 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_download_observer.cc	View	1	5 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm with a nit https://chromiumcodereview.appspot.com/10831363/diff/1/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): https://chromiumcodereview.appspot.com/10831363/diff/1/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode112 chrome/browser/chromeos/gdata/gdata_download_observer.cc:112: BrowserThread::GetBlockingPool()->PostTaskAndReply(FROM_HERE, nit: base::Bind should have ...

8 years, 4 months ago (2012-08-17 08:07:02 UTC) #2

kochi

8 years, 4 months ago (2012-08-17 08:37:11 UTC) #3

Thanks for the review!

The indent is fixed.  submitting..

https://chromiumcodereview.appspot.com/10831363/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right):

https://chromiumcodereview.appspot.com/10831363/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_download_observer.cc:112:
BrowserThread::GetBlockingPool()->PostTaskAndReply(FROM_HERE,
On 2012/08/17 08:07:02, hashimoto wrote:
> nit: base::Bind should have the same indent as FROM_HERE or there should be a
> newline before FROM_HERE.

Done.

Expand Messages | Collapse Messages

Issue 10831363: Remove unnecessary gdata::, fix typos. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix for comment. #

Messages