Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 10831356: Propagate Aura gesture timestamps to WebGestureEvents (Closed)

Created:
8 years, 4 months ago by Rick Byers
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sadrul
Visibility:
Public.

Description

Propagate Aura gesture timestamps to WebGestureEvents We do this for all other input events, it was probably just missed for gesture events. The gesture recognizer appears to use a usefull timestamp value in most cases (the time of the last touch which is what we want except perhaps for timer-based gestures like long press). BUG=143172 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rick Byers
Ben, please review this trivial one-line fix. Thanks, Rick
8 years, 4 months ago (2012-08-16 16:27:23 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-16 18:00:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/10831356/1
8 years, 4 months ago (2012-08-16 18:18:42 UTC) #3
commit-bot: I haz the power
Try job failure for 10831356-1 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-16 22:45:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/10831356/1
8 years, 4 months ago (2012-08-17 01:57:16 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 05:29:29 UTC) #6
Change committed as 152057

Powered by Google App Engine
This is Rietveld 408576698