Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10831349: ProfileImpl fix: Don't access DOMStorageContext too early. (Closed)

Created:
8 years, 4 months ago by marja
Modified:
8 years, 4 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, michaeln, awong
Visibility:
Public.

Description

ProfileImpl fix: Don't access DOMStorageContext too early. Accessing DOMStorageContext requires creating a StoragePartition, and that can't be done before the preferences are loaded. BUG=142656 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/profiles/profile_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
rlp, could you review this patch, too?
8 years, 4 months ago (2012-08-16 11:52:33 UTC) #1
Elliot Glaysher
On 2012/08/16 11:52:33, marja wrote: > rlp, could you review this patch, too? lgtm, but ...
8 years, 4 months ago (2012-08-16 21:31:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10831349/1
8 years, 4 months ago (2012-08-16 21:33:32 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 00:22:28 UTC) #4
Change committed as 152006

Powered by Google App Engine
This is Rietveld 408576698