Issue 10831334: Fixed chromedriver_tests.ExtensionTest.testAppShellView failure due to changes from chrome apps. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(179)

My Issues | Starred Open | Closed | All

Issue 10831334: Fixed chromedriver_tests.ExtensionTest.testAppShellView failure due to changes from chrome apps. (Closed)

Created:
8 years, 4 months ago by Danh Nguyen

Modified:
8 years, 4 months ago

Reviewers:
kkania

CC:
chromium-reviews, kkania

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated test due to changes to API for launching app shell. BUG=142928 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151786

Patch Set 1 #

Patch Set 2 : Fixed issue 142928. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/webdriver/test/app_shell_extension/bg.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Danh Nguyen

Hi Ken, This CL temporarily disables the failed test for now. Could you take a ...

8 years, 4 months ago (2012-08-15 18:56:43 UTC) #1

Danh Nguyen

Hi Ken, I've just uploaded the fix for this issue. Could you take a look? ...

8 years, 4 months ago (2012-08-15 19:46:47 UTC) #2

Danh Nguyen

On 2012/08/15 20:40:31, kkania wrote: > LGTM Thanks Ken. Danh

8 years, 4 months ago (2012-08-15 20:46:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danhn@chromium.org/10831334/1002

8 years, 4 months ago (2012-08-15 20:54:45 UTC) #5

Change committed as 151786

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698