Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2892)

Unified Diff: dart/tests/compiler/dart2js/unparser_test.dart

Issue 10831332: Support new getter syntax. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments and disable one test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/unparser_test.dart
diff --git a/dart/tests/compiler/dart2js/unparser_test.dart b/dart/tests/compiler/dart2js/unparser_test.dart
index c3b2ab8ba71ea68a338cda75e795104ef33dbf00..01afe5cb15dff207558257a74fe9d2c9ad8f6284 100644
--- a/dart/tests/compiler/dart2js/unparser_test.dart
+++ b/dart/tests/compiler/dart2js/unparser_test.dart
@@ -194,12 +194,12 @@ testVariableDefinitions() {
testGetSet() {
// Top-level get/set.
- testDart2Dart('set foo(arg){}get foo(){return 5;}main(){foo; foo=5;}');
+ testDart2Dart('set foo(arg){}get foo{return 5;}main(){foo; foo=5;}');
// Field get/set.
testDart2Dart('main(){var a=new A(); a.foo; a.foo=5;}'
- 'class A{set foo(a){}get foo(){return 5;}}');
+ 'class A{set foo(a){}get foo{return 5;}}');
// Typed get/set.
- testDart2Dart('String get foo(){return "a";}main(){foo;}');
+ testDart2Dart('String get foo{return "a";}main(){foo;}');
}
testFactoryConstructor() {
@@ -415,7 +415,7 @@ testLibraryGetSet() {
var librarySrc = '''
#library('mylib');
-get topgetset() => 5;
+get topgetset => 5;
set topgetset(arg) {}
''';
var mainSrc = '''
@@ -433,9 +433,9 @@ main() {
}
''';
var expectedResult =
- 'get p_topgetset()=> 5;'
+ 'get p_topgetset=> 5;'
'set p_topgetset(arg){}'
- 'get topgetset()=> 6;'
+ 'get topgetset=> 6;'
'set topgetset(arg){}'
'main(){topgetset; topgetset=6; p_topgetset; p_topgetset=5;}';
testDart2DartWithLibrary(mainSrc, librarySrc,
@@ -473,6 +473,6 @@ main() {
testDefaultClassWithArgs();
testClassExtendsWithArgs();
testStaticInvocation();
- testLibraryGetSet();
+ // testLibraryGetSet(); // http://dartbug.com/4604
testFieldTypeOutput();
}

Powered by Google App Engine
This is Rietveld 408576698