Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 10831318: Fix for ninja build (Closed)

Created:
8 years, 4 months ago by cjhopman
Modified:
8 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix for ninja build There is no need to specify the dir for these ant filelists. In ninja these paths are relative while they are absolute in make. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/ant/chromium-jars.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
8 years, 4 months ago (2012-08-15 01:09:30 UTC) #1
Yaron
lgtm
8 years, 4 months ago (2012-08-15 01:09:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10831318/1
8 years, 4 months ago (2012-08-15 01:10:14 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 04:05:04 UTC) #4
Change committed as 151644

Powered by Google App Engine
This is Rietveld 408576698