Issue 10831309: Diagnostics UI: checking in PNG resources first in a separate CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831309: Diagnostics UI: checking in PNG resources first in a separate CL. (Closed)

Created:
8 years, 4 months ago by hshi1

Modified:
8 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Diagnostics UI: checking in PNG resources first in a separate CL. BUG=139442 TEST=build works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151510

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A	chrome/browser/resources/chromeos/diagnostics/fail.png	View	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/chromeos/diagnostics/tick.png	View	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/chromeos/diagnostics/warning.png	View	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

hshi1

Hi Xiyuan, can you review this? As you suggested, I'm landing the PNG resources first ...

8 years, 4 months ago (2012-08-14 17:41:46 UTC) #1

lgtm