Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 10831307: Upstream minor iOS crypto diffs. (Closed)

Created:
8 years, 4 months ago by msarda
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Upstream minor iOS crypto diffs. This CL upstreams two minor changes of crypto for iOS: * nss_util.cc: On iOS, the default NSS root certificates need to be initialized when no persistent database is used. * symmetric_key_unittest.cc: Turn off an OS X-specific code path for iOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M crypto/nss_util.cc View 2 chunks +4 lines, -1 line 0 comments Download
M crypto/symmetric_key_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
msarda
PTAL.
8 years, 4 months ago (2012-08-14 14:48:56 UTC) #1
stuartmorgan
LGTM, but the second bullet in the CL description seems backwards. I'd just say that ...
8 years, 4 months ago (2012-08-14 15:03:24 UTC) #2
Ryan Sleevi
lgtm
8 years, 4 months ago (2012-08-14 17:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/10831307/1
8 years, 4 months ago (2012-08-14 17:30:06 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 19:46:29 UTC) #5
Change committed as 151545

Powered by Google App Engine
This is Rietveld 408576698