Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 10831299: Allow links in refactored panels to open in a tab (like current panel behavior). (Closed)

Created:
8 years, 4 months ago by jennb
Modified:
8 years, 4 months ago
Reviewers:
jianli
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Allow links in refactored panels to open in a tab (like current panel behavior). BUG=127323 TEST=Click on a link in an extension's Panel and verify link opens in a tab. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151909

Patch Set 1 #

Patch Set 2 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/ui/panels/panel_host.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jennb
Got permission from jam to use FindOrCreateTabbedBrowser for this change. Jenn
8 years, 4 months ago (2012-08-14 01:06:44 UTC) #1
jennb
FYI, I'll wait for Ben Well's patch: http://codereview.chromium.org/10825317/ Ben's patch will allow me to avoid ...
8 years, 4 months ago (2012-08-14 18:18:29 UTC) #2
jianli
lgtm
8 years, 4 months ago (2012-08-16 00:32:22 UTC) #3
jennb
Will commit this now and create a new patch after Ben's patch lands. This is ...
8 years, 4 months ago (2012-08-16 00:34:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10831299/3003
8 years, 4 months ago (2012-08-16 00:34:54 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 00:34:56 UTC) #6
Presubmit check for 10831299-3003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Banned functions were used.
    chrome/browser/ui/panels/panel_host.cc:92:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698