Issue 10831297: Attempt 2 at: Makes Window not change focus and send out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831297: Attempt 2 at: Makes Window not change focus and send out (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Attempt 2 at: Makes Window not change focus and send out notifications when moving to a new parent. I had to update a couple of test expectations. BUG=137342 TEST=covered by tests TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151478

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -24 lines)			Patch
M	ui/aura/window.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/aura/window.cc	View		4 chunks	+30 lines, -23 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	3 chunks	+52 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

sky

I had to revert because a test needed to be updated. I updated the test ...

8 years, 4 months ago (2012-08-14 14:57:04 UTC) #1

lgtm