|
|
Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS) Modified:
8 years, 4 months ago CC:
chromium-reviews, arv (Not doing code reviews) Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFixed autocomplete URL for Cloud Print to open real page.
BUG=113354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151799
Patch Set 1 : #
Messages
Total messages: 17 (0 generated)
lgtm
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Gene, please take a look.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
Presubmit check for 10831290-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Missing LGTM from an OWNER for files in these directories: chrome/browser/resources Was the presubmit check useful? Please send feedback & hate mail to maruel@chromium.org!
Hi Erik, please review as owner.
stamp lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
Try job failure for 10831290-1 (previous was lost) (retry) on mac_rel for step "browser_tests". It's a second try, previously, step "browser_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
Try job failure for 10831290-1 (retry) on mac_rel for step "browser_tests". It's a second try, previously, step "browser_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
I have fixed CL. Previous patch fixed issue only because it has error and manifest was not loaded.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/7003
Change committed as 151799 |