Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 10831290: Fixed autocomplete URL for Cloud Print (Closed)

Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fixed autocomplete URL for Cloud Print to open real page. BUG=113354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151799

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/cloud_print_app/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 4 months ago (2012-08-13 17:58:16 UTC) #1
Vitaly Buka (NO REVIEWS)
8 years, 4 months ago (2012-08-13 17:59:18 UTC) #2
Aleksey Shlyapnikov
lgtm
8 years, 4 months ago (2012-08-13 18:03:51 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-13 18:04:54 UTC) #4
Vitaly Buka (NO REVIEWS)
Gene, please take a look.
8 years, 4 months ago (2012-08-13 18:16:39 UTC) #5
gene
lgtm
8 years, 4 months ago (2012-08-13 18:28:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
8 years, 4 months ago (2012-08-13 18:40:25 UTC) #7
commit-bot: I haz the power
Presubmit check for 10831290-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-13 18:40:28 UTC) #8
Vitaly Buka (NO REVIEWS)
Hi Erik, please review as owner.
8 years, 4 months ago (2012-08-13 18:46:33 UTC) #9
Dan Beam
stamp lgtm
8 years, 4 months ago (2012-08-15 00:35:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
8 years, 4 months ago (2012-08-15 00:36:57 UTC) #11
commit-bot: I haz the power
Try job failure for 10831290-1 (previous was lost) (retry) on mac_rel for step "browser_tests". It's ...
8 years, 4 months ago (2012-08-15 02:17:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/1
8 years, 4 months ago (2012-08-15 05:33:48 UTC) #13
commit-bot: I haz the power
Try job failure for 10831290-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 06:57:33 UTC) #14
Vitaly Buka (NO REVIEWS)
I have fixed CL. Previous patch fixed issue only because it has error and manifest ...
8 years, 4 months ago (2012-08-15 21:52:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10831290/7003
8 years, 4 months ago (2012-08-15 21:52:58 UTC) #16
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 00:24:12 UTC) #17
Change committed as 151799

Powered by Google App Engine
This is Rietveld 408576698