Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10831286: Set TCP_KEEPALIVE idle and interval on Android. (Closed)

Created:
8 years, 4 months ago by Philippe
Modified:
8 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Set TCP_KEEPALIVE idle and interval on Android. This is part of Chrome for Android upstreaming. It affects how long our side of an idle TCP socket can know the other end has closed the connection. The default value is 2 hours which is too long. We should use the same values on Linux. BUG=136750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/socket/tcp_client_socket_libevent.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Philippe
8 years, 4 months ago (2012-08-13 16:41:28 UTC) #1
mmenke
LGTM. Two hours does seem a mite long.
8 years, 4 months ago (2012-08-13 17:39:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10831286/1
8 years, 4 months ago (2012-08-14 07:38:27 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 09:50:59 UTC) #4
Change committed as 151447

Powered by Google App Engine
This is Rietveld 408576698