Issue 10831280: [Mac] Website settings: Add cookie info & permission icons, plus other visual fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831280: [Mac] Website settings: Add cookie info & permission icons, plus other visual fixes. (Closed)

Created:
8 years, 4 months ago by Patrick Dubroy

Modified:
8 years, 4 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Website settings: Add cookie info & permission icons, plus other visual fixes. Changes to the UI to bring it closer to the mocks: - Add cookies section to Permissions tab, and add "Cookies" and "Permissions" headers. - Change identity status text to green when the site identity is verified. - Add permission icons to the Permissions tab. BUG=135407 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151448

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -50 lines)			Patch
M	chrome/browser/ui/cocoa/website_settings_bubble_controller.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings_bubble_controller.mm	View		19 chunks	+183 lines, -40 lines	1 comment	Download
M	chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm	View	1	4 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

8 years, 4 months ago (2012-08-13 17:44:57 UTC) #2

LGTM

http://codereview.chromium.org/10831280/diff/3002/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings_bubble_controller.mm (right):

http://codereview.chromium.org/10831280/diff/3002/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings_bubble_controller.mm:358: cookiesView_
= [[WebsiteSettingsContentView alloc]
These are leaked.

Expand Messages | Collapse Messages